Allowing pyro to generate empty transforms

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Allowing pyro to generate empty transforms

Heath Stewart-3
Bob, I'm a bit confused by the question / thread here: https://github.com/wixtoolset/wix3/pull/156
 
Generally, empty transforms should not be included in a patch because it impacts install performance of both patches and bundles that include them, and any supersedence bits can revert valid patches if people aren't careful (combined with a much older change I made to create fake patch families when including all changes).


Heath Stewart
Software Design Engineer
Visual Studio, Microsoft
http://blogs.msdn.com/heaths
 

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/wix-devs
Reply | Threaded
Open this post in threaded view
|

Re: Allowing pyro to generate empty transforms

Bob Arnson-6
On 06-Dec-14 01:13, Heath Stewart wrote:
Bob, I'm a bit confused by the question / thread here: https://github.com/wixtoolset/wix3/pull/156
 
Generally, empty transforms should not be included in a patch because it impacts install performance of both patches and bundles that include them, and any supersedence bits can revert valid patches if people aren't careful (combined with a much older change I made to create fake patch families when including all changes).
Rob's suggestion is that we allow it by default and throw a warning. Right now, it's an error and -aet turns it into a warning. Since empty transforms are legal (but useless/dumb), it seems it should be a warning, which makes the switch low-value.
-- 
sig://boB
http://joyofsetup.com/

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/wix-devs