Structuring Pull Request(s) for Bug 4791

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Structuring Pull Request(s) for Bug 4791

John Cooper-2

I’ve got some working code I’m trying to break right now, so I’ll be submitting pull requests as soon as testing is completed.


I think it may be desirable to divide up into multiple pull requests.  I would like to discuss/recommend breaking up my changes as follows:


1)      CompareFiles method in BinderFileManager.cs

2)      Adding a WixSharingViolationException

3)      LayoutMedia() in WixBinder.cs and MoveFIle() and CopyFile in BinderFileManager.cs

4)      (Optional) Add .NET Trace Logger Support to lit and light app.config files, etc.



John Merryweather Cooper

Senior Software Engineer | Integration Development Group | Enterprise Notification Service

Jack Henry & Associates, Inc.® | Lenexa, KS  66214 | Ext:  431050 |[hidden email]


NOTICE: This electronic mail message and any files transmitted with it are intended
exclusively for the individual or entity to which it is addressed. The message,
together with any attachment, may contain confidential and/or privileged information.
Any unauthorized review, use, printing, saving, copying, disclosure or distribution
is strictly prohibited. If you have received this message in error, please
immediately advise the sender by reply email and delete all copies.


WiX-devs mailing list
[hidden email]