Wix4: Unit testing
Locked
 
|
What’s the current status of the Wix4 unit testing? It seems like the WXS files have the wrong namespaces so the builders fail. If I repair that, then light fails with LGHT0280 due to a bind variable pointing at a file instead of a path.
Was that an intended change? Thanks, Jacob ------------------------------------------------------------------------------ _______________________________________________ WiX-devs mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/wix-devs |
|
|
I’m also seeing some missing chunks in the binder, ex: /// <summary> /// Populates the variable cache with specific package properties. /// </summary> /// <param name="package">The package with properties to cache.</param> /// <param name="variableCache">The property cache.</param> private static void PopulatePackageVariableCache(ChainPackageInfo package, IDictionary<string, string> variableCache) { string id = package.Id; variableCache.Add(String.Concat("packageDescription.", id), package.Description); variableCache.Add(String.Concat("packageLanguage.", id), package.Language); variableCache.Add(String.Concat("packageManufacturer.", id), package.Manufacturer); variableCache.Add(String.Concat("packageName.", id), package.DisplayName); variableCache.Add(String.Concat("packageVersion.", id), package.Version); } From: Hoover, Jacob [mailto:[hidden email]]
What’s the current status of the Wix4 unit testing? It seems like the WXS files have the wrong namespaces so the builders fail. If I repair that, then light fails with LGHT0280 due to a bind variable pointing at a file instead of a path.
Was that an intended change? Thanks, Jacob ------------------------------------------------------------------------------ _______________________________________________ WiX-devs mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/wix-devs |
|
|
In reply to this post by Hoover, Jacob
There is a lot of old test code that needs to be revamped. The unit tests in “test\test” should be working. The Burn stuff needs some help. Basically, need to do some serious elbow grease on the tests. _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/ From: Hoover, Jacob [mailto:[hidden email]]
What’s the current status of the Wix4 unit testing? It seems like the WXS files have the wrong namespaces so the builders fail. If I repair that, then light fails with LGHT0280 due to a bind variable pointing at a file instead of a path.
Was that an intended change? Thanks, Jacob ------------------------------------------------------------------------------ _______________________________________________ WiX-devs mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/wix-devs |
|
|
In reply to this post by Hoover, Jacob
Bugs. _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/ From: Hoover, Jacob [mailto:[hidden email]]
I’m also seeing some missing chunks in the binder, ex: /// <summary> /// Populates the variable cache with specific package properties. /// </summary> /// <param name="package">The package with properties to cache.</param> /// <param name="variableCache">The property cache.</param> private static void PopulatePackageVariableCache(ChainPackageInfo package, IDictionary<string, string> variableCache) { string id = package.Id; variableCache.Add(String.Concat("packageDescription.", id), package.Description); variableCache.Add(String.Concat("packageLanguage.", id), package.Language); variableCache.Add(String.Concat("packageManufacturer.", id), package.Manufacturer); variableCache.Add(String.Concat("packageName.", id), package.DisplayName); variableCache.Add(String.Concat("packageVersion.", id), package.Version); } From: Hoover, Jacob [[hidden email]]
What’s the current status of the Wix4 unit testing? It seems like the WXS files have the wrong namespaces so the builders fail. If I repair that, then light fails with LGHT0280 due to a bind variable pointing at a file instead of a path.
Was that an intended change? Thanks, Jacob ------------------------------------------------------------------------------ _______________________________________________ WiX-devs mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/wix-devs |
|
|
Part of it was my missing the Command where the code was migrated to, the other part was there are 2 lines commented out which are bugs. Is there a WIP for the refactoring you did I could dig into, so I could
better understand the intent of the change? From: Rob Mensching [mailto:[hidden email]]
Bugs. _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/ From: Hoover, Jacob [[hidden email]]
I’m also seeing some missing chunks in the binder, ex: /// <summary> /// Populates the variable cache with specific package properties. /// </summary> /// <param name="package">The package with properties to cache.</param> /// <param name="variableCache">The property cache.</param> private static void PopulatePackageVariableCache(ChainPackageInfo package, IDictionary<string, string> variableCache) { string id = package.Id; variableCache.Add(String.Concat("packageDescription.", id), package.Description); variableCache.Add(String.Concat("packageLanguage.", id), package.Language); variableCache.Add(String.Concat("packageManufacturer.", id), package.Manufacturer); variableCache.Add(String.Concat("packageName.", id), package.DisplayName); variableCache.Add(String.Concat("packageVersion.", id), package.Version); } From: Hoover, Jacob [[hidden email]]
What’s the current status of the Wix4 unit testing? It seems like the WXS files have the wrong namespaces so the builders fail. If I repair that, then light fails with LGHT0280 due to a bind variable pointing at a file instead of a path.
Was that an intended change? Thanks, Jacob ------------------------------------------------------------------------------ _______________________________________________ WiX-devs mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/wix-devs |
|
|
I didn’t write a WIP for the refactoring since the intent of the change is to just make the code more readable. In the beginning, we created gigantic classes. Later there was an experiment with the “Info” classes
that were more than “Row” classes. That messed up our .wixpdb storage and also made the code really twisty. So, “Info” classes are all going away (as are any properties in “Row” classes that were not backed by an actual Field). Basically, we’re down to “Row” classes store all the data (so it ends up in .wixpdbs) and “Command” objects so we don’t end up with gigantic classes like what Linker and Binder used to be. Note: not updating
the Compiler since haven’t found an efficient way to do the recursive descent parser using objects (and breaking the Compiler into a bunch of partials also feels icky). _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/ From: Hoover, Jacob [mailto:[hidden email]]
Part of it was my missing the Command where the code was migrated to, the other part was there are 2 lines commented out which are bugs. Is there a WIP for the refactoring you did I could dig into, so I could
better understand the intent of the change? From: Rob Mensching [[hidden email]]
Bugs. _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/ From: Hoover, Jacob [[hidden email]]
I’m also seeing some missing chunks in the binder, ex: /// <summary> /// Populates the variable cache with specific package properties. /// </summary> /// <param name="package">The package with properties to cache.</param> /// <param name="variableCache">The property cache.</param> private static void PopulatePackageVariableCache(ChainPackageInfo package, IDictionary<string, string> variableCache) { string id = package.Id; variableCache.Add(String.Concat("packageDescription.", id), package.Description); variableCache.Add(String.Concat("packageLanguage.", id), package.Language); variableCache.Add(String.Concat("packageManufacturer.", id), package.Manufacturer); variableCache.Add(String.Concat("packageName.", id), package.DisplayName); variableCache.Add(String.Concat("packageVersion.", id), package.Version); } From: Hoover, Jacob [[hidden email]]
What’s the current status of the Wix4 unit testing? It seems like the WXS files have the wrong namespaces so the builders fail. If I repair that, then light fails with LGHT0280 due to a bind variable pointing at a file instead of a path.
Was that an intended change? Thanks, Jacob ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ WiX-devs mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/wix-devs |
| Free forum by Nabble | Edit this page |